Skip to content

fix(web): retain skipped environments in update summaries - #1076

Open
incognitojam wants to merge 2 commits into
mainfrom
styal/retain-skipped-update-summary
Open

incognitojam wants to merge 2 commits into
mainfrom
styal/retain-skipped-update-summary

Conversation

@incognitojam

@incognitojam incognitojam commented Oct 25, 2026 •

Copy link
Copy Markdown
Owner

Update everything could finish with a success notification even when a selected environment was skipped, and a desktop relaunch discarded the skipped reason. Retain those reasons in the final summary, including skips discovered while the update runs. A partially completed update uses a warning notification; actual failures remain errors.

Exercised successful, failed, and entirely skipped updates, late skips, saved-result restoration after relaunch, and older saved results. The browser comparison uses synthetic machines with the production summary functions and toast component. The after view retains “Skipped Test machine: not connected.” An OS installer relaunch was not performed; persistence is exercised through the actual saved schema and launch notice.

Before After
Skipped reason lost Skipped reason retained

Written by an agent (Codex, gpt-6.1-sol).

@github-actions

Copy link
Copy Markdown

Upstream divergence

Both sides are compared with upstream at the in-order tip 3982f20ce4. Excludes .repos/ and pnpm-lock.yaml.

Measure Base This PR Change
Upstream files the fork changes 1,683 1,684 +1
Lines changed in them 91,598 91,666 +68
Upstream files the fork removes 49 49 0
Fork-only files 661 662 +1
Fork-only lines 118,803 118,892 +89

Upstream files that start to differ (1)

  • apps/web/src/components/sidebar/updateEverything.logic.test.ts: +40 −1 from upstream
Upstream files whose difference changes (4)
File Change Now differs by
apps/web/src/components/sidebar/updateEverything.logic.ts +22 23 lines
apps/web/src/components/sidebar/updateEverythingRun.tsx +2 29 lines
docs/user/updating.md +2 140 lines
apps/web/src/components/sidebar/useUpdateEverything.ts +1 91 lines

@github-actions

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ The exact PR base did not have a successful artifact. Baseline uses the latest successful main measurement shown below.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 4.9 KiB 4.9 KiB 0 B (0.0%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 20.8 KiB 20.8 KiB 0 B (0.0%) 29.3 KiB ✅
Codex Live turn messages 1 1 0 (0.0%) 8 ✅
Claude Total thread wire 5.0 KiB 5.0 KiB −7 B (−0.1%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.2 KiB 1.2 KiB −7 B (−0.6%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.2 KiB 21.2 KiB 0 B (0.0%) 29.3 KiB ✅
Claude Live turn messages 2 2 0 (0.0%) 8 ✅

Baseline: 5648afe · PR result: 136b6b5 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant